git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Choose XDL_FAST_HASH code on sizeof(long) instead of __WORDSIZE

From
Junio C Hamano <gitster@pobox.com>
Date
May 1, 2012, 17:33 UTC
Message-ID
<7vhavzajrp.fsf@alter.siamese.dyndns.org>
In-Reply-To
<399c9a1f0dd548da3144eff3c50d04a8f343ab24.1335860033.git.trast@student.ethz.ch>
Thomas Rast <trast@student.ethz.ch> writes:
Show 9 quoted lines
> Darwin does not define __WORDSIZE, and compiles the 32-bit code path
> on 64-bit systems, resulting in a totally broken git.
>
> I could not find an alternative -- other than the platform symbols
> (__x86_64__ etc.) -- that does the test in the preprocessor.  However,
> we can also just test for the size of a 'long', which is what really
> matters here.  Any compiler worth its salt will leave only the branch
> relevant for its platform, and indeed on Linux/GCC the numbers don't
> change:
Thanks.
Previous: Thomas RastNext: David Aguilar
Message 7 of 9 in “XDL_FAST_HASH breaks git on OS X 10.7.3”
  1. Brian GernhardtApr 29, 2012
  2. Thomas RastApr 30, 2012
  3. Brian GernhardtMay 1, 2012
  4. Junio C HamanoMay 1, 2012
  5. Junio C HamanoMay 1, 2012
  6. Choose XDL_FAST_HASH code on sizeof(long) instead of __WORDSIZEThomas Rast, May 1, 2012
  7. Junio C HamanoMay 1, 2012
  8. David AguilarMay 1, 2012
  9. Junio C HamanoMay 1, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.