Re: [PATCH/RFC v4 01/16] GSOC remote-svn

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 18, 2012, 20:13 UTC
Message-ID: <7vzk5srm9w.fsf@alter.siamese.dyndns.org>
In-Reply-To: <8572000.QUVXl8yetS@flobuntu>

Florian Achleitner <florian.achleitner.2.6.31@gmail.com> writes:

Show 10 quoted lines

> On Friday 17 August 2012 21:16:59 Junio C Hamano wrote:
>> Comments from mentors and people interested in remote helpers?
>> 
>> I did minimum line wrapping, typofix and small compilation fixes
>> and queued these on 'pu'; I think I saw one commit whose message
>> I didn't quite get what it was trying to say, and another that was
>> missing S-o-b (I left them untouched).
>
> Should I provide a better version? I found the commit that I forgot to sign-
> off, but I'm not sure which message you mean.

There was a one with "E.g:" followed by an incomplete sentence that did not parse for me. Can you fetch 'pu', run format-patch on your topic and compare the output with what you sent to the list?

Show 8 quoted lines

>> The result merged to 'pu' seems to fail 9020, by the way.
>
> That's because contrib/svn-fe isn't built automatically if you call make in 
> the toplevel dir. 
> It dies with "fatal: Unable to find remote helper for 'svn'", because the 
> helper is not built. We currently need to run make in contrib/svn-fe 
> seperately.
> That's a bit awkward.

That indicates that one necessary patch to add logic to Makefile to go and build that subdirectory, at least before running the test, but possibly as part of the "all" target, is missing, isn't it?

Or you can add, at the beginning of your tests files that require the contrib bit, to have something like

	if test -e "$GIT_BUILD_DIR/remote-svn"
        then
		test_set_prereq REMOTE_SVN
	fi

and protect your tests with the prerequisite, e.g.

	test_expect_success REMOTE_SVN 'test svn:// URL' '
        	...
	'

without changing the top-level Makefile.