Re: [PATCH/RFC v4 01/16] GSOC remote-svn

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 20, 2012, 16:23 UTC
Message-ID: <7vk3wtleh7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <6231669.WggyDX4Xa3@flomedio>

Florian Achleitner <florian.achleitner.2.6.31@gmail.com> writes:

Show 23 quoted lines

> On Saturday 18 August 2012 13:13:47 Junio C Hamano wrote:
>> That indicates that one necessary patch to add logic to Makefile to
>> go and build that subdirectory, at least before running the test,
>> but possibly as part of the "all" target, is missing, isn't it?
>> 
>> Or you can add, at the beginning of your tests files that require
>> the contrib bit, to have something like
>> 
>>         if test -e "$GIT_BUILD_DIR/remote-svn"
>>         then
>>                 test_set_prereq REMOTE_SVN
>>         fi
>> 
>> and protect your tests with the prerequisite, e.g.
>> 
>>         test_expect_success REMOTE_SVN 'test svn:// URL' '
>>                 ...
>>         '
>> 
>> without changing the top-level Makefile.
>
> What version would you prefer? Currently nothing in contrib/ is built by the 
> toplevel Makefile..

The latter approach of running tests only for people who went to contrib/vcs-svn and built things there may be more conservative. I could be persuaded either way.