Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 4, 2012, 16:58 UTC
Message-ID: <7vzk55bu8s.fsf@alter.siamese.dyndns.org>
In-Reply-To: <003601cd8a0f$6a792840$3f6b78c0$@schmitz-digital.de>

"Joachim Schmitz" <jojo@schmitz-digital.de> writes:

Show 8 quoted lines

>> If you cannot re-trigger the timer, then you will see "20%" shown
>> after one second, silence for 4 seconds and then "done", for an
>> operation that takes 5 seconds.  Which is not the end of the world,
>> though.  It does not affect correctness.
>
> That does seem to work, if I do e.g. a "git clone" on git itself
> (being a fairly large repository), I see it updating the % values
> about once per second.

Ehh, so somebody is re-arming the alarm(). I am not sure where, though.

 ... thinks for a while, then a lightbulb slowly starts to glow ...

Where are you cloning from, and does the other side of the clone (i.e. upload-pack) also run on your tandem port? If you are cloning from one of my public distribution points (e.g. k.org, repo.or.cz, or github.com), then I think the progress indicator you are seeing is coming from the other side, not generated by your local timer.

Only with the observation of "clone", I cannot tell if your timer is working. You can try repacking the test repository you created by your earlier "git clone" with "git repack -a -d -f" and see what happens.

Show 7 quoted lines

> OK, I'll go for that one-liner in git-compat-utils.h then
>
> #ifdef NO_SETITIMER /* poor man's setitimer() */
> #define setitimer(w,v,o) alarm((v)->it_value.tv_sec+((v)->it_value.tv_usec>0))
> #endif
>
> It certainly seems to work just fine for me.