RE: [PATCH 1/2] Support for setitimer() on platforms lacking it
- From
Joachim Schmitz <jojo@schmitz-digital.de>
- Date
- Sep 4, 2012, 21:47 UTC
- Message-ID
- <002c01cd8ae6$f23d7ec0$d6b87c40$@schmitz-digital.de>
- In-Reply-To
- <7vobllaami.fsf@alter.siamese.dyndns.org>
Show 31 quoted lines
> From: Junio C Hamano [mailto:gitster@pobox.com] > Sent: Tuesday, September 04, 2012 8:47 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org; 'Johannes Sixt' > Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it > > Junio C Hamano <gitster@pobox.com> writes: > > > "Joachim Schmitz" <jojo@schmitz-digital.de> writes: > > > >>> Only with the observation of "clone", I cannot tell if your timer is > >>> working. You can try repacking the test repository you created by > >>> your earlier "git clone" with "git repack -a -d -f" and see what > >>> happens. > >> > >> It does update the counter too. > > > > Yeah, that was not a very good way to diagnose it. > > > > You see the progress from pack-objects (which is the underlying > > machinery "git repack" uses) only because it knows how many objects > > it is going to pack, and it updates the progress meter for every > > per-cent progress it makes, without any help from the timer > > interrupt. > > I think the "Counting objects: $number" phase is purely driven by > the timer, as there is no way to say "we are done X per-cent so > far". > > Doesn't your repack show "Counting objects: " with a number once, > pause forever and then show "Counting objects: $number, done."?
Yes, only once, when it is done $ ./git repack -a -d -f warning: no threads support, ignoring --threads Counting objects: 140302, done. Compressing objects: 1% (1385/138407)