Re: [PATCH 3/3] git-apply --whitespace=nowarn

From: Junio C Hamano <junkio@cox.net>
Date: Feb 28, 2006, 05:08 UTC
Message-ID: <7vy7zwt6hq.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <4403C303.70602@gmail.com>

A Large Angry SCM <gitzilla@gmail.com> writes:

Show 9 quoted lines

> Junio C Hamano wrote:
>> Andrew insists --whitespace=warn should be the default, and I
>> tend to agree.  This introduces --whitespace=warn, so if your
>> project policy is more lenient, you can squelch them by having
>> apply.whitespace=nowarn in your configuration file.
>> Signed-off-by: Junio C Hamano <junkio@cox.net>
>
> I think this is wrong. The default policy of, non-security, tools
> SHOULD be the least restrictive and most flexible.

The reason is that --whitespace=warn does not refuse to apply but spits out some warning messages. Admittedly, going from zero, any amount of new warning message makes it infinitely more chatty, but then people can squelch it by having the configuration option "apply.whitespace = nowarn".