Re: the war on trailing whitespace

From: Junio C Hamano <junkio@cox.net>
Date: Feb 26, 2006, 03:38 UTC
Message-ID: <7v1wxq7psj.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060225174047.0e9a6d29.akpm@osdl.org>

Andrew Morton <akpm@osdl.org> writes:

> It's invariably pointless to add lines which have trailing whitespace. 
> Nobody cares much, but my scripts spam me when it happens, so I've become
> obsessive....

I do not call me obsessive, but I do enable pre-commit and pre-applypatch hooks I ship with git myself.

> I realise that we cannot do this when doing git fetches, but when importing
> patches and mboxes, git ought to whine loudly about input which matches the
> above regexp, and it should offer an option to tidy it up.  Perhaps by
> default.

I stole the policy the sample hook scripts use from you; it is not enabled by default, and as the tool manufacturer I am a bit reluctant to do so.

However, as a kernel project maintainer high in the foodchain, I'd imagine your plea to your fellow maintainers who apply patches using git tools would be heard well.