Re: [PATCH] gitweb: bugfix: a.list formatting regression
- From
Junio C Hamano <junkio@cox.net>
- Date
- Aug 22, 2006, 23:14 UTC
- Message-ID
- <7vy7tgl5vx.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <ecg1fd$3uj$2@sea.gmane.org>
Jakub Narebski <jnareb@gmail.com> writes:
Show 18 quoted lines
> Junio C Hamano wrote: > >> It might be worthwhile to do a full sweep of the pages we >> generate and identify what classes we would want. I have a >> feeling that we overuse a.list for example -- they are all in >> some form of list alright but they might benefit from a bit >> finer logical separatoin. One list is enumaration of refs and >> another is a chronological sequence of commits. >> >> Then people who would want to tweak the presentation would have >> an easier time changing only gitweb.css. > > Next patch in this series of patches > [PATCH] gitweb: Replace some presentational HTML by CSS > Message-Id: <11562431392439-git-send-email-jnareb@git.vger.kernel.org> > adds "name" subclass (a.list.name) for ref names. (I think > subclasses/multiple classes is the way to do it, as all a.list > elements have something in common: use next class to divide).
I agree about the implementation aspect, such as using "list.name" as class names; I was suggesting to start from design.