Re: [PATCH] gitweb: bugfix: a.list formatting regression

From: Junio C Hamano <junkio@cox.net>
Date: Aug 22, 2006, 22:34 UTC
Message-ID: <7vr6z8mmb7.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <11562409683011-git-send-email-jnareb@git.vger.kernel.org>

Jakub Narebski <jnareb@git.vger.kernel.org> writes:

Show 19 quoted lines

> From: Jakub Narebski <jnareb@gmail.com>
>
> Fix regression introduced by
> commit 17d07443188909ef5f8b8c24043cb6d9fef51bca.
>
> "a.list" being "bold", makes a myriad of things shown by
> gitweb in bold font-weight, which is a regression from
> pre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior.
>
> The fix is to add "subject" class and use this class
> to replace pre-format_subject_html formatting of subject
> (comment) via using (or not) <b>...</b> element. This
> should go back to the pre-17d0744318... style.
>
> Regression noticed by Luben Tuikov.
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> ---

I haven't seen an Ack from Luben for the proposed renaming of the class, although I very much like naming things for what they mean (i.e. "subject"), not what they do (i.e. "bold") myself.

It might be worthwhile to do a full sweep of the pages we generate and identify what classes we would want. I have a feeling that we overuse a.list for example -- they are all in some form of list alright but they might benefit from a bit finer logical separatoin. One list is enumaration of refs and another is a chronological sequence of commits.

Then people who would want to tweak the presentation would have an easier time changing only gitweb.css.