git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Make cvsexportcommit work with filenames containing spaces.

From
Junio C Hamano <junkio@cox.net>
Date
Sep 29, 2006, 06:37 UTC
Message-ID
<7vy7s3npo9.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<200609290128.56217.robin.rosenberg@dewire.com>

Please do not do more than one patch per e-mail; I'll have to save the attachment in separate files and manually make commits, which is more work.

The build procedure for the release to build rpms runs testsuite as part of it, so I need to think a bit how to proceed with this patch. Leaving the test failing on FC5 means I won't be able to cut binary releases. Checking early in the test script to see if "patch" can grok a diff for a file with whitespaces, and skipping the whitespace test if we have a bad "patch", seems to the best workaround.

BTW, the addition of TAB to the patch tail is done by "git diff" automatically for files with whitespace in them in the proposed updates version in "pu" (and it is done conditionally only for files whose names have whitespace), so I think your fix will become redundant when it graduates to "master".

Previous: Robin RosenbergNext: Robin Rosenberg
Message 6 of 7 in “Make cvsexportcommit work with filenames containing spaces.”
  1. Make cvsexportcommit work with filenames containing spaces.Robin Rosenberg, Sep 22, 2006
  2. Junio C HamanoSep 23, 2006
  3. Robin RosenbergSep 23, 2006
  4. Junio C HamanoSep 23, 2006
  5. Robin RosenbergSep 28, 2006
  6. Junio C HamanoSep 29, 2006
  7. Robin RosenbergSep 29, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.