Re: [PATCH] Make cvsexportcommit work with filenames containing spaces.

From: Junio C Hamano <junkio@cox.net>
Date: Sep 23, 2006, 19:03 UTC
Message-ID: <7v4puytnh0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200609231427.55721.robin.rosenberg@dewire.com>

Robin Rosenberg <robin.rosenberg@dewire.com> writes:

Show 8 quoted lines

> Why patch? Well this patch works around (i.e. not perfect) a mismatch between 
> what patch eats and git submits. They are not totally, compatible, and I'm 
> not sure who to blame yet.  git emits diff's without timestamps, and what 
> matters to patch, without a TAB before the file timestamp. When patch sees a 
> header like "+++ filename with spaces.txt" it patches "filename". When it 
> sees "+++ filename with spaces.txt<TAB>" if patches "filename with 
> spaces.txt". The real fix would ofcourse be in git diff or patch sometime in 
> the future.

Ah, it might be because our diff output do not have trailing TAB (and timestamp) and if CVS uses GNU patch that would be confused and not detect the file being patched.

Interestingly, I did a two-patch series to address that issue separately. But that is not even in "next" yet.

More interestingly, the version of "GNU patch" that cannot grok our patch (without trailing TAB) for a file that has SP in its name is on my home machine where your patched cvsexportcommit works. I do not know if GNU patch on the other machine does.

Will collect necessary info and follow up.