git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: Update and fix Makefile

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 9, 2008, 08:19 UTC
Message-ID
<7vy7azl8bs.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<18308.17099.334609.80415@cargo.ozlabs.ibm.com>
Paul Mackerras <paulus@samba.org> writes:
Show 9 quoted lines
> Junio C Hamano writes:
>
>> I see somwhat funny spacing there.  I'd suggest giving up
>> aligning with spaces and consistently saying "var ?= val"
>> instead.
>
> I made those lines all have one space before and after the ?=, and
> committed Christian's patches (plus one from Gerrit Pape), and pushed
> it out.  Please do a pull.
There were a couple of things I noticed that made me somewhat curious:
 * There are more spaces around ?= in Christian's patch to Makefile.
 * You have two patches from Christian and one patch from
   Gerrit; the author and commit timestamps of these commits are
   the same and in your timezone.
but nothing to complain about.  Pulled and pushed out.
Previous: Paul MackerrasNext: Junio C Hamano
Message 4 of 10 in “gitk: Update and fix Makefile”
  1. gitk: Update and fix MakefileChristian Stimming, Jan 8, 2008
  2. Junio C HamanoJan 8, 2008
  3. Paul MackerrasJan 9, 2008
  4. Junio C HamanoJan 9, 2008
  5. Junio C HamanoJan 11, 2008
  6. Junio C HamanoJan 11, 2008
  7. Paul MackerrasJan 11, 2008
  8. Junio C HamanoJan 11, 2008
  9. Jeff KingJan 12, 2008
  10. Christian StimmingJan 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.