From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 09 Jan 2008 08:19:35 GMT
Subject: Re: [PATCH] gitk: Update and fix Makefile
Message-ID: <7vy7azl8bs.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <18308.17099.334609.80415@cargo.ozlabs.ibm.com>

Paul Mackerras <paulus@samba.org> writes:

> Junio C Hamano writes:
>
>> I see somwhat funny spacing there.  I'd suggest giving up
>> aligning with spaces and consistently saying "var ?= val"
>> instead.
>
> I made those lines all have one space before and after the ?=, and
> committed Christian's patches (plus one from Gerrit Pape), and pushed
> it out.  Please do a pull.

There were a couple of things I noticed that made me somewhat curious:

 * There are more spaces around ?= in Christian's patch to Makefile.

 * You have two patches from Christian and one patch from
   Gerrit; the author and commit timestamps of these commits are
   the same and in your timezone.

but nothing to complain about.  Pulled and pushed out.