git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] add definitions for global variables to shell.c

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 19, 2008, 00:29 UTC
Message-ID
<7vy72tkfu0.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080818123727.GB11842@schiele.dyndns.org>
Robert Schiele <rschiele@gmail.com> writes:
Show 7 quoted lines
> Commit 5b8e6f85 introduced stubs for three functions that make no sense
> for git-shell.  But those stubs defined libgit.a functions a second time
> so that a linker can complain.  While commit 78568448 fixes this problem
> it introduces a new issue on the affected systems: Some versions of the
> Sun compiler generate references to global variables when they see
> extern declarations for those, even when they are never used in the
> code.

Haven't looked at the real declarations but if the decl are "extern" and nobody refers to them, why should the resulting object file require them to be defined anywhere? If the decl are not and in (fortran-ish) "common" section, on the other hand, you shouldn't have to define them yourself like this either.

This sounds like a compiler bug to me.
Previous: Robert SchieleNext: Robert Schiele
Message 2 of 13 in “add definitions for global variables to shell.c”
  1. add definitions for global variables to shell.cRobert Schiele, Aug 18, 2008
  2. Junio C HamanoAug 19, 2008
  3. Robert SchieleAug 19, 2008
  4. Junio C HamanoAug 19, 2008
  5. Robert SchieleAug 19, 2008
  6. Johannes SixtAug 19, 2008
  7. Robert SchieleAug 19, 2008
  8. Junio C HamanoAug 19, 2008
  9. 1/2 shell: do not play duplicated definition games to shrink the executableJunio C Hamano, Aug 20, 2008
  10. 2/2 Build-in "git-shell"Junio C Hamano, Aug 20, 2008
  11. Johannes SixtAug 20, 2008
  12. Junio C HamanoAug 20, 2008
  13. Robert SchieleAug 20, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.