git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] add definitions for global variables to shell.c

From
Robert Schiele <rschiele@gmail.com>
Date
Aug 19, 2008, 09:18 UTC
Message-ID
<20080819091830.GG11842@schiele.dyndns.org>
In-Reply-To
<48AA8931.1030009@viscovery.net>
On Tue, Aug 19, 2008 at 10:49:53AM +0200, Johannes Sixt wrote:
Show 5 quoted lines
> Why not just revert 5b8e6f85f (shrink git-shell)? It was a nice try. If it
> had not proved as a maintainance burden, it would have had merits. But who
> these days cares whether git-shell takes 300K or 30K in the light of that
> it goes out of the way anyway by execing some other process at the first
> opportunity?

Sounds reasonable to me. Doing this in a clean way would require more restructuring in the code. So far this change started a chain of changes where each change tried to solve one issue and caused a more severe one.

Though it would not only be 5b8e6f85 to be reverted but also 78568448 that tried to fix up problems that 5b8e6f85 caused.

Robert
-- 
Robert Schiele
Dipl.-Wirtsch.informatiker	mailto:rschiele@gmail.com

"Quidquid latine dictum sit, altum sonatur."
Previous: Johannes SixtNext: Junio C Hamano
Message 7 of 13 in “add definitions for global variables to shell.c”
  1. add definitions for global variables to shell.cRobert Schiele, Aug 18, 2008
  2. Junio C HamanoAug 19, 2008
  3. Robert SchieleAug 19, 2008
  4. Junio C HamanoAug 19, 2008
  5. Robert SchieleAug 19, 2008
  6. Johannes SixtAug 19, 2008
  7. Robert SchieleAug 19, 2008
  8. Junio C HamanoAug 19, 2008
  9. 1/2 shell: do not play duplicated definition games to shrink the executableJunio C Hamano, Aug 20, 2008
  10. 2/2 Build-in "git-shell"Junio C Hamano, Aug 20, 2008
  11. Johannes SixtAug 20, 2008
  12. Junio C HamanoAug 20, 2008
  13. Robert SchieleAug 20, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.