Re: [PATCH 1/4] test-suite: adding a test for fast-export with tag variants

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 23, 2009, 03:41 UTC
Message-ID: <7vy6uw9a8p.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <40aa078e0903221755n23457ba6m689aad34c0ec8214@mail.gmail.com>

Erik Faye-Lund <kusmabite@googlemail.com> writes:

Show 9 quoted lines

> On Mon, Mar 23, 2009 at 1:39 AM, Junio C Hamano <gitster@pobox.com> wrote:
> ...
>> These tests seem to only care about fast-export not dying, but don't we
>> also want to check if they produce correct results?
>
> Well, yeah. But I was working mainly on fixing a crash-bug here, and I
> don't think I know enough about the correct output of fast-export to
> pull this off. Perhaps tighting up the test is something someone else
> would care to do?

Surely; for a starter, saying something like this:

+# NEEDSWORK: not just check return status, but validate the output +test_expect_failure 'tree_tag' 'git fast-export tree_tag' +test_expect_failure 'tree_tag-obj' 'git fast-export tree_tag-obj' +test_expect_failure 'tag-obj_tag' 'git fast-export tag-obj_tag' +test_expect_failure 'tag-obj_tag-obj' 'git fast-export tag-obj_tag-obj'

would do, and will invite others to fill the gap when they have time.

Thanks.