git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/4] builtin-fast-export.c: handle nested tags

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Mar 22, 2009, 21:50 UTC
Message-ID
<1237758620-6116-4-git-send-email-kusmabite@gmail.com>
In-Reply-To
<1237758620-6116-3-git-send-email-kusmabite@gmail.com>

When tags that points to tags are passed to fast-export, an error saying "Tag [TAGNAME] points nowhere?". This fix calls parse_object() on the object before referencing it's tag, to ensure the tag-info is fully initialized. In addition, it inserts a comment to point out where nested tags are handled. This is consistent with the comment for signed tags.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
 builtin-fast-export.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/builtin-fast-export.c b/builtin-fast-export.c
index c3ce320..8083c5f 100644
--- a/builtin-fast-export.c
+++ b/builtin-fast-export.c
@@ -362,7 +362,10 @@ static void get_tags_and_duplicates(struct object_array *pending,
 			break;
 		case OBJ_TAG:
 			tag = (struct tag *)e->item;
+
+			/* handle nested tags */
 			while (tag && tag->object.type == OBJ_TAG) {
+				parse_object(tag->object.sha1);
 				string_list_append(full_name, extra_refs)->util = tag;
 				tag = (struct tag *)tag->tagged;
 			}
-- 
1.6.2.1.226.gcb2dd
Previous: Erik Faye-LundNext: Junio C Hamano
Message 4 of 9 in “test-suite: adding a test for fast-export with tag variants”
  1. 1/4 test-suite: adding a test for fast-export with tag variantsErik Faye-Lund, Mar 22, 2009
  2. 2/4 builtin-fast-export.c: turn error into warningErik Faye-Lund, Mar 22, 2009
  3. 3/4 builtin-fast-export.c: fix crash on tagged treesErik Faye-Lund, Mar 22, 2009
  4. 4/4 builtin-fast-export.c: handle nested tagsErik Faye-Lund, Mar 22, 2009
  5. Junio C HamanoMar 23, 2009
  6. Erik Faye-LundMar 23, 2009
  7. Junio C HamanoMar 23, 2009
  8. Erik Faye-LundMar 23, 2009
  9. Junio C HamanoMar 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.