git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: bsd group semantics

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 31, 2009, 20:26 UTC
Message-ID
<7vy6ul4exy.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20090331184604.GA10701@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 12 quoted lines
> On Tue, Mar 31, 2009 at 10:32:14AM -0700, Junio C Hamano wrote:
>
>> My point was if I belong only to my personal group and git.git work tree
>> is owned by junio.junio to begin with, you would never be able to notice
>> any breakage with such a test.
>
> Ah, I see. Yes, you would need to belong to at least two groups to make
> such a test feasible.
>
> Such a requirement is generally outside the scope of running the
> test suite; do you want to just ditch the g+s test, then, or do you want
> me to work up something conditional based on the Makefile flag?

For now, I'd suggest teaching the test not to care about g+s bit. After all, they are about giving correct mode bits to files and directories. Correct mode bits for group do not mean anything if you make them owned by a wrong group, but that is not something we have tested so far, and can be a separate test anyway.

Previous: Jeff KingNext: Jeff King
Message 6 of 9 in “bsd group semantics”
  1. Jeff KingMar 31, 2009
  2. Junio C HamanoMar 31, 2009
  3. Jeff KingMar 31, 2009
  4. Junio C HamanoMar 31, 2009
  5. Jeff KingMar 31, 2009
  6. Junio C HamanoMar 31, 2009
  7. Jeff KingMar 31, 2009
  8. Junio C HamanoMar 31, 2009
  9. Jeff KingMar 31, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.