Re: [PATCH] mergetool--lib: add p4merge as a pre-configured mergetool option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 28, 2009, 07:18 UTC
- Message-ID
- <7vy6mwt2af.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20091027230043.GA11607@hashpling.org>
Charles Bailey <charles@hashpling.org> writes:
Show 7 quoted lines
> On Tue, Oct 27, 2009 at 03:36:49PM -0700, Scott Chacon wrote: >> p4merge is now a built-in diff/merge tool. >> This adds p4merge to git-completion and updates >> the documentation to mention p4merge. >> --- > > I approve (but haven't had a chance to test this).
Thanks; eventually you two need Sign-off and Acked-by, then, but I sense that an undate to address the points below is in order?
Show 5 quoted lines
> I'm just wondering, does this work well with unixes and Mac OS X? I > think it's recommended install practice to symlink p4v as p4merge on > *nix, but Mac OS X needs some sort of 'launchp4merge' to be called > IIRC, or is this something that users can just configure with > mergetool.p4diff.path?