Re: [PATCH] mergetool--lib: add p4merge as a pre-configured mergetool option
- From
Jay Soffian <jaysoffian@gmail.com>
- Date
- Oct 30, 2009, 03:00 UTC
- Message-ID
- <76718490910292000t7b024b83y68d71b6ff810c15@mail.gmail.com>
- In-Reply-To
- <200910300202.02016.markus.heidelberg@web.de>
On Thu, Oct 29, 2009 at 9:02 PM, Markus Heidelberg <markus.heidelberg@web.de> wrote:
> He didn't mean p4merge on other platforms, but other merge tools on Mac > OS X. What about all the other merge tools already in mergetool--lib? > Should they get special handling, too?
If someone wants to scratch that itch, then yes. The default diff tool for OS X has its helper already in /usr/bin (opendiff). p4merge is arguably a better merge tool, and it installs as an app bundle in /Applications. I'm not sure about the other diff tools, I haven't looked.
> And for Windows we could add C:\Program Files\MergeToolX\tool.exe for > every merge tool.
If it makes those tools easier to use with git, and if someone on Windows wants to scratch that itch, then yes, we should.
> But where will we end?
I don't understand this argument. It's a few lines of code to make git a little friendlier. We end when folks stop contributing patches because either no one cares of there's nothing left to improve.
j.