git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: support core.whitespace rules in diff view

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 20, 2010, 23:43 UTC
Message-ID
<7vy69stop2.fsf@alter.siamese.dyndns.org>
In-Reply-To
<87pqv4fqqz.fsf_-_@fox.patthoyts.tk>
Pat Thoyts <patthoyts@users.sourceforge.net> writes:
Show 9 quoted lines
> This is a rather more complete implementation of whitespace highlighting
> according to the core.whitespace setting. The diff view whitespace
> highlights should match what you see with 'git diff' when color is
> enabled for all the whitespace rules except cr-at-eol where there is
> currently a rule to hide these.
>
> Suggested-by: Tor Arvid Lund <torarvid@gmail.com>
> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
> ---

This might be a very stupid question, but isn't it an easier-to-maintain option to let underlying "git diff" color its output and convert the ANSI coloring to whatever Tcl wants to use, especially in the long run, instead of trying to replicate the logic to check whitespace breakages here?

Previous: Pat ThoytsNext: Tor Arvid Lund
Message 5 of 14 in “Colored whitespace in git gui”
  1. Tor Arvid LundOct 18, 2010
  2. git-gui: highlight trailing whitespace in diff viewPat Thoyts, Oct 19, 2010
  3. Tor Arvid LundOct 20, 2010
  4. git-gui: support core.whitespace rules in diff viewPat Thoyts, Oct 20, 2010
  5. Junio C HamanoOct 20, 2010
  6. Tor Arvid LundOct 21, 2010
  7. Pat ThoytsOct 21, 2010
  8. Tor Arvid LundOct 22, 2010
  9. Pat ThoytsOct 22, 2010
  10. git-gui: apply color information from git diffPat Thoyts, Oct 21, 2010
  11. Kevin BallardOct 21, 2010
  12. Pat ThoytsOct 21, 2010
  13. git-gui: apply color information from git diff outputPat Thoyts, Oct 22, 2010
  14. Tor Arvid LundOct 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.