From: Junio C Hamano Date: Wed, 20 Oct 2010 23:43:53 GMT Subject: Re: [PATCH] git-gui: support core.whitespace rules in diff view Message-ID: <7vy69stop2.fsf@alter.siamese.dyndns.org> In-Reply-To: <87pqv4fqqz.fsf_-_@fox.patthoyts.tk> Pat Thoyts writes: > This is a rather more complete implementation of whitespace highlighting > according to the core.whitespace setting. The diff view whitespace > highlights should match what you see with 'git diff' when color is > enabled for all the whitespace rules except cr-at-eol where there is > currently a rule to hide these. > > Suggested-by: Tor Arvid Lund > Signed-off-by: Pat Thoyts > --- This might be a very stupid question, but isn't it an easier-to-maintain option to let underlying "git diff" color its output and convert the ANSI coloring to whatever Tcl wants to use, especially in the long run, instead of trying to replicate the logic to check whitespace breakages here?