git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] convert filter: supply path to external driver

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 20, 2010, 08:52 UTC
Message-ID
<7vy67kddx3.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4D0F0DFB.20502@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> writes:
> What happens if there are any shell special characters in the path name
> (or spaces, for that matter). Does this shell-escape the substituted path
> name anywhere in the call chain?
Good eyes.  Thanks.

You would need something like %'s (that is "'" modifier applied to 's' placeholder in strbuf_expand() to cause the expansion sq'ed), and then the caller must write something like

	clean = git-p4-filter --clean '%s'
Previous: Johannes SixtNext: Pete Wyckoff
Message 16 of 17 in “smudge/clean filter needs filename”
  1. Pete WyckoffDec 18, 2010
  2. convert filter: supply path to external driverPete Wyckoff, Dec 19, 2010
  3. Junio C HamanoDec 19, 2010
  4. Jeff KingDec 20, 2010
  5. david@lang.hmDec 20, 2010
  6. convert filter: supply path to external driverPete Wyckoff, Dec 20, 2010
  7. Junio C HamanoDec 20, 2010
  8. convert filter: supply path to external driverPete Wyckoff, Dec 21, 2010
  9. Jonathan NiederDec 21, 2010
  10. convert filter: supply path to external driverPete Wyckoff, Dec 21, 2010
  11. Junio C HamanoDec 21, 2010
  12. convert filter: supply path to external driverPete Wyckoff, Dec 22, 2010
  13. Junio C HamanoDec 22, 2010
  14. Junio C HamanoDec 22, 2010
  15. Johannes SixtDec 20, 2010
  16. Junio C HamanoDec 20, 2010
  17. Pete WyckoffDec 20, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.