From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 20 Dec 2010 08:52:24 GMT
Subject: Re: [PATCH] convert filter: supply path to external driver
Message-ID: <7vy67kddx3.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4D0F0DFB.20502@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

> What happens if there are any shell special characters in the path name
> (or spaces, for that matter). Does this shell-escape the substituted path
> name anywhere in the call chain?

Good eyes.  Thanks.

You would need something like %'s (that is "'" modifier applied to 's'
placeholder in strbuf_expand() to cause the expansion sq'ed), and then the
caller must write something like

	clean = git-p4-filter --clean '%s'