Re: [PATCH, v2] tag: implement --[no-]strip option

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 15, 2011, 07:17 UTC
Message-ID: <7vy5vhx3an.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4EC209C7.6090805@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

Show 18 quoted lines

> Am 11/14/2011 22:43, schrieb Kirill A. Shutemov:
>> From: "Kirill A. Shutemov" <kirill@shutemov.name>
>> 
>> --strip::
>> 	Remove from tag message lines staring with '#', trailing spaces
>
> s/staring/starting/
>
>> 	from every line and empty lines from the beginning and end.
>> 	Enabled by default. Use --no-strip to overwrite the behaviour.
>> 
>> --no-strip is useful if you want to take a tag message as-is, without
>> any stripping.
>
> I would like to know why this is useful. Tag messages are for human
> consumption. What benefit is it that whitespace is not stripped? Why are
> lines starting with '#' so important that they need to stay in the tag
> message?

A conversion from foreign SCM comes to mind, but that is somewhat an unfair comment, given that I know by heart how stripspace works and the above documentation patch incorrectly describes what it does.

Besides stripping "# comment", stripspace collapses consecutive blank lines, removes trailing blank lines and trailing whitespaces at the end of lines.