git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH, v2] tag: implement --[no-]strip option

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 14, 2011, 23:04 UTC
Message-ID
<7vehxai9w5.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20111114223903.GA5751@shutemov.name>
"Kirill A. Shutemov" <kirill@shutemov.name> writes:
Show 21 quoted lines
>> > @@ -356,7 +362,7 @@ static void create_tag(const unsigned char *object, const char *tag,
>> >  
>> >  		if (!is_null_sha1(prev))
>> >  			write_tag_body(fd, prev);
>> > -		else
>> > +		else if (opt->strip)
>> >  			write_or_die(fd, _(tag_template), strlen(_(tag_template)));
>> 
>> Why are you not writing template when no strip is done? (Not an objection
>> disguised as a rhetorical question, but a question).
>> 
>> The user who typed "tag -a v1.2.3 HEAD" that spawns an editor would still
>> find it useful to have commented instructions, once we start filling the
>> template with more useful information that is customized for the
>> situation (e.g. "git show -s --oneline" output), no?
>
> Yes. But in this case commented instructions will not be stripped and they
> will go to the message. I think user will be confused.
>
> We can show show some instructions before spawning the editor. What do
> you think?

My knee-jerk reaction is that it would be worse than what your patch does. I'd say we'd start from your patch and see how users of 'next' reacts while the topic is cooking.

Previous: Kirill A. ShutemovNext: Johannes Sixt
Message 4 of 6 in “tag: implement --[no-]strip option”
  1. tag: implement --[no-]strip optionKirill A. Shutemov, Nov 14, 2011
  2. Junio C HamanoNov 14, 2011
  3. Kirill A. ShutemovNov 14, 2011
  4. Junio C HamanoNov 14, 2011
  5. Johannes SixtNov 15, 2011
  6. Junio C HamanoNov 15, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.