git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4] git-p4: add initial support for RCS keywords

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 22, 2012, 19:29 UTC
Message-ID
<7vy5ruacpa.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120222125327.GA2292@padd.com>
Pete Wyckoff <pw@padd.com> writes:
Show 5 quoted lines
>> Improved-by: Pete Wyckoff <pw@padd.com>
>> Signed-off-by: Luke Diamand <luke@diamand.org>
>
> Looks brilliant.  Ack.  Thanks for suffering through N rounds of
> review.  :)

Well, I hate to say that I need to ask another round, to redo this patch on top of ld/git-p4-expanded-keywords topic that has already been in 'next'; a patch that replaces what is in 'next' will lose fix-ups for issues I pointed out in the first round that you forgot to follow and were fixed up locally by me when I queued the existing one.

When working on an improvement to what you have sent out, please make it a habit of comparing your result with what are already queued, even when the earlier patches are still in 'pu'. They often are polished with trivial improvements (both to the patch and the log message) based on review comments from people when they are queued, which you do not want to lose.

Thanks.
Previous: Pete WyckoffNext: Luke Diamand
Message 4 of 5 in “[PATCHv4] git-p4: RCS keyword handling”
  1. Luke DiamandFeb 22, 2012
  2. [PATCHv4] git-p4: add initial support for RCS keywordsLuke Diamand, Feb 22, 2012
  3. Pete WyckoffFeb 22, 2012
  4. Junio C HamanoFeb 22, 2012
  5. Luke DiamandFeb 22, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.