From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 22 Feb 2012 19:29:53 GMT
Subject: Re: [PATCHv4] git-p4: add initial support for RCS keywords
Message-ID: <7vy5ruacpa.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120222125327.GA2292@padd.com>

Pete Wyckoff <pw@padd.com> writes:

>> Improved-by: Pete Wyckoff <pw@padd.com>
>> Signed-off-by: Luke Diamand <luke@diamand.org>
>
> Looks brilliant.  Ack.  Thanks for suffering through N rounds of
> review.  :)

Well, I hate to say that I need to ask another round, to redo this patch
on top of ld/git-p4-expanded-keywords topic that has already been in
'next'; a patch that replaces what is in 'next' will lose fix-ups for
issues I pointed out in the first round that you forgot to follow and were
fixed up locally by me when I queued the existing one.

When working on an improvement to what you have sent out, please make it a
habit of comparing your result with what are already queued, even when the
earlier patches are still in 'pu'.  They often are polished with trivial
improvements (both to the patch and the log message) based on review
comments from people when they are queued, which you do not want to lose.

Thanks.