Re: [PATCH v2 2/2] pickaxe: allow -i to search in patch case-insensitively

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 29, 2012, 08:55 UTC
Message-ID: <7vy5rmt3w8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120229083534.GC14181@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

>> When given the "--regexp-ignore-case" (or "-i") option, which originally
>> was designed to affect case sensitivity of the search done in the commit
>> log part, e.g. "log --grep", the matches made with -S/-G pickaxe search is
>> done case insensitively now.
>
> I can't imagine anybody would want to have different case-sensitivity
> options for grepping the commit message versus pickaxe. But even if they
> do, and we later add options to control them individually, we would
> still want the short-and-sweet "-i" to cover the common case of setting
> both. So I think the approach is good.

What you didn't read in the above is that the devilq around "-i" is not in the case insensitivity switch between log-part grep (--grep/--author) and patch part grep (-S/-G), but how it interacts with generating the patch part case insensitively (i.e. "log -p --ignore-case", which is also "-i").

You can see what I decided to do in an evil merge in 'pu'.

In short,

  * The short-and-sweet "-i" means both --regexp-ignore-case (grep) and
    --ignore-case (diff); and

  * The long-hand can be used to ask for case
    insensitive grep but case sensitive patch, or vice versa.