Re: [PATCH v2 2/2] pickaxe: allow -i to search in patch case-insensitively

From: Jeff King <peff@peff.net>
Date: Feb 29, 2012, 08:35 UTC
Message-ID: <20120229083534.GC14181@sigill.intra.peff.net>
In-Reply-To: <1330474831-9030-3-git-send-email-gitster@pobox.com>

On Tue, Feb 28, 2012 at 04:20:31PM -0800, Junio C Hamano wrote:

Show 14 quoted lines

> "git log -S<string>" is a useful way to find the last commit in the
> codebase that touched the <string>. As it was designed to be used by a
> porcelain script to dig the history starting from a block of text that
> appear in the starting commit, it never had to look for anything but an
> exact match.
> 
> When used by an end user who wants to look for the last commit that
> removed a string (e.g. name of a variable) that he vaguely remembers,
> however, it is useful to support case insensitive match.
> 
> When given the "--regexp-ignore-case" (or "-i") option, which originally
> was designed to affect case sensitivity of the search done in the commit
> log part, e.g. "log --grep", the matches made with -S/-G pickaxe search is
> done case insensitively now.

I can't imagine anybody would want to have different case-sensitivity options for grepping the commit message versus pickaxe. But even if they do, and we later add options to control them individually, we would still want the short-and-sweet "-i" to cover the common case of setting both. So I think the approach is good.

The patch itself looks fine to me.

-Peff