Re: [PATCH/RFC] remove #!interpreter line from shell libraries

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 12, 2012, 19:50 UTC
Message-ID: <7vy5r5r43s.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F5E4618.10102@xiplink.com>

Marc Branchaud <marcnarc@xiplink.com> writes:

Show 14 quoted lines

> On 12-03-09 02:58 AM, Clemens Buchacher wrote:
>> Hi Jonathan,
>> 
>> On Thu, Mar 08, 2012 at 06:14:04AM -0600, Jonathan Nieder wrote:
>>>
>>> --- a/git-mergetool--lib.sh
>>> +++ b/git-mergetool--lib.sh
>>> @@ -1,5 +1,4 @@
>>> -#!/bin/sh
>>> -# git-mergetool--lib is a library for common merge tool functions
>>> +# git-mergetool--lib is a shell library for common merge tool functions
>> 
>> This breaks vim's filetype detection. It can still guess the file type
>> from the .sh extension, but we strip the extension during the build.

Then that _is_ a feature to make it more obvious that the file is not something you should be editing, no?

> How about a modeline ...
> (Now I'll wince and duck as people "calmly" discuss the merits of putting
> editor-specific modelines in the source code, and especially which editors
> deserve such treatment...)

Please, no "Local Variables:" or "# vim:". Just don't impose personal taste in editor settings to others.