git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] remove #!interpreter line from shell libraries

From
Clemens Buchacher <drizzd@aon.at>
Date
Mar 9, 2012, 07:58 UTC
Message-ID
<20120309075820.GA15985@ecki>
In-Reply-To
<20120308121403.GA16493@burratino>
Hi Jonathan,
On Thu, Mar 08, 2012 at 06:14:04AM -0600, Jonathan Nieder wrote:
Show 7 quoted lines
>
> --- a/git-mergetool--lib.sh
> +++ b/git-mergetool--lib.sh
> @@ -1,5 +1,4 @@
> -#!/bin/sh
> -# git-mergetool--lib is a library for common merge tool functions
> +# git-mergetool--lib is a shell library for common merge tool functions

This breaks vim's filetype detection. It can still guess the file type from the .sh extension, but we strip the extension during the build. Although one should typically work with the source files, in the past I did have a look at the installed files on a few occasions. Maybe because I did not know better, or because the source code was not available to me. So for me, this outweighs the aesthetic advantages, if any.

Clemens
Previous: Jeff KingNext: Marc Branchaud
Message 3 of 8 in “remove #!interpreter line from shell libraries”
  1. remove #!interpreter line from shell librariesJonathan Nieder, Mar 8, 2012
  2. Jeff KingMar 8, 2012
  3. Clemens BuchacherMar 9, 2012
  4. Marc BranchaudMar 12, 2012
  5. Jonathan NiederMar 12, 2012
  6. Clemens BuchacherMar 13, 2012
  7. Junio C HamanoMar 12, 2012
  8. Clemens BuchacherMar 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.