git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] shell-prompt: clean up nested if-then

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 19, 2013, 16:28 UTC
Message-ID
<7vy5ek6zf0.fsf@alter.siamese.dyndns.org>
In-Reply-To
<5123350D.4010802@xs4all.nl>
Simon Oosthoek <s.oosthoek@xs4all.nl> writes:
> I suppose it would be fine if a patch was sent to update the entire
> git-prompt.sh code to be more in line with the Git shell script style...

Please don't. We do not want a "style conversion" for the sole purpose of conversion, especially when a subsystem is already internally consistent.

Besides, the git-prompt.sh thing needs to be fairly bash specific so the usual "Git Porcelain scripts targetted for POSIX/Bourne shells" rules does not apply there.

> My original gripe was just with doing it in one place while leaving all
> the others unchanged. It makes for messy reading and leads to confusion.
Yes, it is always preferred to match the _local_ convention.
Previous: Simon Oosthoek
Message 8 of 8 in “shell-prompt: clean up nested if-then”
  1. shell-prompt: clean up nested if-thenMartin Erik Werner, Feb 18, 2013
  2. Jonathan NiederFeb 18, 2013
  3. Martin Erik WernerFeb 18, 2013
  4. shell-prompt: clean up nested if-thenmartinerikwerner@gmail.com, Feb 18, 2013
  5. Jonathan NiederFeb 18, 2013
  6. Junio C HamanoFeb 18, 2013
  7. Simon OosthoekFeb 19, 2013
  8. Junio C HamanoFeb 19, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.