From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 19 Feb 2013 16:28:35 GMT
Subject: Re: [PATCH] shell-prompt: clean up nested if-then
Message-ID: <7vy5ek6zf0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <5123350D.4010802@xs4all.nl>

Simon Oosthoek <s.oosthoek@xs4all.nl> writes:

> I suppose it would be fine if a patch was sent to update the entire
> git-prompt.sh code to be more in line with the Git shell script style...

Please don't.  We do not want a "style conversion" for the sole
purpose of conversion, especially when a subsystem is already
internally consistent.

Besides, the git-prompt.sh thing needs to be fairly bash specific so
the usual "Git Porcelain scripts targetted for POSIX/Bourne shells"
rules does not apply there.

> My original gripe was just with doing it in one place while leaving all
> the others unchanged. It makes for messy reading and leads to confusion.

Yes, it is always preferred to match the _local_ convention.