git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] [submodule] Remove duplicate call to set_rev_name

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 21, 2013, 17:03 UTC
Message-ID
<7vy5a3mm4v.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20130620215812.GA2687@sandbox-ub>
Heiko Voigt <hvoigt@hvoigt.net> writes:
Show 10 quoted lines
> Hi,
>
> On Mon, Jun 17, 2013 at 11:55:36AM +0200, Fredrik Gustafsson wrote:
>> set_rev_name is a possible expensive operation. If a submodule has
>> changes in it, set_rev_name was called twice.
>> 
>> Solution is to move set_rev_name so it's only called once, no matter the
>> codepath taken.
>
> Looks good to me.
Thanks.
Previous: Heiko Voigt
Message 3 of 3 in “[submodule] Remove duplicate call to set_rev_name”
  1. [submodule] Remove duplicate call to set_rev_nameFredrik Gustafsson, Jun 17, 2013
  2. Heiko VoigtJun 20, 2013
  3. Junio C HamanoJun 21, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.