From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 21 Jun 2013 17:03:44 GMT
Subject: Re: [PATCH] [submodule] Remove duplicate call to set_rev_name
Message-ID: <7vy5a3mm4v.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130620215812.GA2687@sandbox-ub>

Heiko Voigt <hvoigt@hvoigt.net> writes:

> Hi,
>
> On Mon, Jun 17, 2013 at 11:55:36AM +0200, Fredrik Gustafsson wrote:
>> set_rev_name is a possible expensive operation. If a submodule has
>> changes in it, set_rev_name was called twice.
>> 
>> Solution is to move set_rev_name so it's only called once, no matter the
>> codepath taken.
>
> Looks good to me.

Thanks.