Re: [PATCH] Deb Packaging fixes: Build against Mozilla libs for Debian, conflict with "git"

From: Junio C Hamano <junkio@cox.net>
Date: Jul 24, 2005, 06:12 UTC
Message-ID: <7vwtngg2bd.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200507240728.40158.snake@penza-gsm.ru>

Alexey Nezhdanov <snake@penza-gsm.ru> writes:

> Satturday, 23 July 2005 23:26 Ryan Anderson wrote:
>> -Depends: ${misc:Depends}, shellutils, diff, rsync, rcs
>> +Depends: ${misc:Depends}, patch, diff, rsync, rcs, ssh
> Did I missed something or you forgot about libcurl3 dependency?

I think you are right. In the build process, dh_shlibdeps is used and shlib:Depends is created to include the libcurl3 (among other things) in debian/git-core.substvars, but it is not actually used in the resulting binary package because the line misses ${shlibs:Depends} there.

Ryan, would this change be enough? I do not know what I am doing (${misc:Depends} is new to me), but this patch seems to fix it on my box.

------------ Make sure binary debian package depends on shlibs it uses.

The "Depends:" line in debian/control lacked ${shlibs:Depends}, which caused the resulting binary package not to depend on libcurl3 nor even libc6 ;-).

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

# - linus: Fix up applymbox script for the addition of "git-" prefix # + (working tree)

diff --git a/debian/control b/debian/control
--- a/debian/control
+++ b/debian/control
@@ -7,7 +7,7 @@ Standards-Version: 3.6.1
 
 Package: git-core
 Architecture: any
-Depends: ${misc:Depends}, shellutils, diff, rsync, rcs
+Depends: ${shlibs:Depends} ${misc:Depends}, shellutils, diff, rsync, rcs
 Description: The git content addressable filesystem
  GIT comes in two layers. The bottom layer is merely an extremely fast
  and flexible filesystem-based database designed to store directory trees