Re: [PATCH] Deb Packaging fixes: Build against Mozilla libs for Debian, conflict with "git"

From: Junio C Hamano <junio@twinsun.com>
Date: Jul 23, 2005, 09:11 UTC
Message-ID: <7vd5p9horr.fsf@totally-fudged-out-message-id>
In-Reply-To: <20050723073707.GA3255@mythryan2.michonline.com>

Ryan Anderson <ryan@michonline.com> writes:

> --- a/debian/changelog
> +++ b/debian/changelog
> ...
> +  * Minor tweaks to the Build-Depends.

This is a nit and not the reason for NACK, but I do not see any change to Build-Depends.

> -Depends: ${misc:Depends}, shellutils, diff, rsync, rcs
> +Depends: ${misc:Depends}, patch, diff, rsync, rcs, wget, rsh-client

This is primarily my fault, but this new Depends line is already obsolete. Darrin Thompson removed the last remaining use of wget and it is my understanding that we do not depend on wget anymore; instead we now depend on curl executable.

I do not offhand remember where we use rsh-client. The rsh-client I know of is this one, which claims to offer rsh, rcp and rlogin but I do not think we use any of them. Did you mean "ssh" package?

    Package: rsh-client
    Priority: extra
    Section: net
    Maintainer: Alberto Gonzalez Iniesta <agi@inittab.org>
    Source: netkit-rsh
    Version: 0.17-13
    Description: rsh clients.
     This package contains rsh, rcp and rlogin.

Perhaps (I am not sure about the rsh-client vs ssh):

> +Depends: ${misc:Depends}, patch, diff, rsync, rcs, curl, ssh

Both the use of mozilla SHA1 library and conflicting with the other GIT, which are the primary points of this patch, sound sensible, relative to the Debian poli(cies|tics), but as long as we are touching the Depends: line, let's make sure we get it right (the current one is obviously obsolete).