Re: [PATCH] Support ent:relative_path

From: Junio C Hamano <junkio@cox.net>
Date: May 4, 2007, 19:38 UTC
Message-ID: <7vwszos7l2.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0705042127390.4015@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 5 quoted lines

> For me, "v1.5.1:" means something similar to ssh: it is a distant 
> revision. It is not a complete filesystem. I think of revisions as 
> something more general than a directory, but less general than a 
> filesystem. And thus, it makes perfect sense to me that "v1.5.1:Makefile" 
> means the main Makefile, no matter where I am in the current repository.

I see merits in both sides' arguments.

Saying "path out of THIS version" anchors your mindset at the top of that version, so in that sense v1.5.1:Makefile should mean the toplevel no matter where you are. However...

> Now, I agree that often you want to compare some file in the current 
> directory to the corresponding file in a certain revision. That is why 
> git-diff has a different idea, and indeed, a different notation, too.

... don't you expect "git show HEAD@{yesterday}:git.txt" while in Documentation/ subdirectory to work? I wonder if the current alternative "git show HEAD@{yesterday}:Documentation/git.txt" a bit unintuitive.