git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] test-suite: adding a test for fast-export with tag variants

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 29, 2009, 21:32 UTC
Message-ID
<7vwsa8ow10.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<40aa078e0903291305p28ec2ae8xf0cb465e593af0b0@mail.gmail.com>
Erik Faye-Lund <kusmabite@googlemail.com> writes:
> OK, I see now that the previous patch-series has been merged to "pu".
> Is there a reason why this updated patch-series hasn't superseded it?

Even if the tested program crashes, it is Ok to test them inside expect_failure, so I'd suggest not commenting the first two out.

But running the tests with the first patch applied to the same base as where v1 was applied gives this, which is a more serious issue:

    $ sh t9301-fast-export.sh 2>&1 | tail -n 2
    * still have 4 known breakage(s)
    * failed 6 among remaining 15 test(s)

In other words, the changes to the set-up part seem to break unrelated tests. Why can such an update supersede the previous one?

Previous: Erik Faye-LundNext: Erik Faye-Lund
Message 6 of 8 in “test-suite: adding a test for fast-export with tag variants”
  1. 1/4 test-suite: adding a test for fast-export with tag variantsErik Faye-Lund, Mar 23, 2009
  2. 2/4 builtin-fast-export.c: turn error into warningErik Faye-Lund, Mar 23, 2009
  3. 3/4 builtin-fast-export.c: fix crash on tagged treesErik Faye-Lund, Mar 23, 2009
  4. 4/4 builtin-fast-export.c: handle nested tagsErik Faye-Lund, Mar 23, 2009
  5. Erik Faye-LundMar 29, 2009
  6. Junio C HamanoMar 29, 2009
  7. Erik Faye-LundMar 29, 2009
  8. Junio C HamanoMar 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.