git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] builtin-fast-export.c: turn error into warning

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Mar 23, 2009, 12:53 UTC
Message-ID
<1237812789-1360-2-git-send-email-kusmabite@gmail.com>
In-Reply-To
<1237812789-1360-1-git-send-email-kusmabite@gmail.com>

fast-import doesn't have a syntax to support tree-objects (and some other object-types), so fast-export shouldn't handle them. However, aborting the operation is a bit drastic. This patch turns the error into a warning instead.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
 builtin-fast-export.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/builtin-fast-export.c b/builtin-fast-export.c
index fdf4ae9..02bad1f 100644
--- a/builtin-fast-export.c
+++ b/builtin-fast-export.c
@@ -378,8 +378,10 @@ static void get_tags_and_duplicates(struct object_array *pending,
 			}
 			break;
 		default:
-			die ("Unexpected object of type %s",
-			     typename(e->item->type));
+			warning("%s: Unexpected object of type %s, skipping.",
+			        e->name,
+			        typename(e->item->type));
+			continue;
 		}
 		if (commit->util)
 			/* more than one name for the same object */
-- 
1.6.2.1.225.g9a4a0.dirty
Previous: Erik Faye-LundNext: Erik Faye-Lund
Message 2 of 8 in “test-suite: adding a test for fast-export with tag variants”
  1. 1/4 test-suite: adding a test for fast-export with tag variantsErik Faye-Lund, Mar 23, 2009
  2. 2/4 builtin-fast-export.c: turn error into warningErik Faye-Lund, Mar 23, 2009
  3. 3/4 builtin-fast-export.c: fix crash on tagged treesErik Faye-Lund, Mar 23, 2009
  4. 4/4 builtin-fast-export.c: handle nested tagsErik Faye-Lund, Mar 23, 2009
  5. Erik Faye-LundMar 29, 2009
  6. Junio C HamanoMar 29, 2009
  7. Erik Faye-LundMar 29, 2009
  8. Junio C HamanoMar 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.