git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] check-ref-format --print: Normalize refnames that start with slashes

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 29, 2011, 22:22 UTC
Message-ID
<7vwrdv503k.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110829185011.GC756@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 8 quoted lines
> ... I always assumed that you did one of:
>
>   1. Comment on the patch via email, just as any other reviewer, so it
>      can go into the re-roll.
>
>   2. Fix-up the patch or commit message during "am", with the assumption
>      that it is ready to be merged at least to "next", at which point
>      re-rolls are no longer OK, anyway.
Not really.

I usually amend patches queued to 'pu' (or queue fixup! separately) when I am reasonably confident that my suggestion had enough merits. Also I roll in suggestions that are obviously (to me) good from the list, which may or may not be the same to the list concensus. Maybe I should try to be less aggressive.

Show 9 quoted lines
> I mentioned "it takes effort" above. I don't mean "submitters shouldn't
> be expected to put in extra effort". But we should make sure the effort
> is well-spent, which means:
>
>   1. Giving them some indication that you tweaked things during
>      application. It doesn't have to be an inclusive list. Even saying
>      "Thanks, applied with some spelling fixes" instead of your usual
>      "Thanks" is enough (actually, I think you frequently do so
>      already).

Just started consciously doing so yesterday, after starthing this offtopic therad ;-)

Previous: Jeff KingNext: Michael Haggerty
Message 12 of 14 in “Fix reference name format check and normalization”
  1. 0/2 Fix reference name format check and normalizationMichael Haggerty, Aug 27, 2011
  2. 1/2 check-ref-format --print: Normalize refnames that start with slashesMichael Haggerty, Aug 27, 2011
  3. Michael HaggertyAug 27, 2011
  4. Junio C HamanoAug 27, 2011
  5. git project patch workflowMichael Haggerty, Aug 28, 2011
  6. Jeff KingAug 29, 2011
  7. Jeff KingAug 29, 2011
  8. Junio C HamanoAug 29, 2011
  9. Jeff KingAug 29, 2011
  10. Johannes SixtAug 29, 2011
  11. Jeff KingAug 29, 2011
  12. Junio C HamanoAug 29, 2011
  13. 2/2 Forbid DEL characters in reference namesMichael Haggerty, Aug 27, 2011
  14. Junio C HamanoAug 27, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.