[PATCH v2 2/2] Forbid DEL characters in reference names
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Aug 27, 2011, 04:12 UTC
- Message-ID
- <1314418364-2532-3-git-send-email-mhagger@alum.mit.edu>
- In-Reply-To
- <1314418364-2532-1-git-send-email-mhagger@alum.mit.edu>
DEL is an ASCII control character and therefore should not be permitted in reference names. Add tests for this and other unusual characters.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> ---
Please check that the uses of "printf" in the test script are portable and quoted correctly.
refs.c | 2 +- t/t1402-check-ref-format.sh | 3 +++ 2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/refs.c b/refs.c index 3a8789d..0fa8dcf 100644 --- a/refs.c +++ b/refs.c @@ -837,7 +837,7 @@ int for_each_rawref(each_ref_fn fn, void *cb_data) static inline int bad_ref_char(int ch) { - if (((unsigned) ch) <= ' ' || + if (((unsigned) ch) <= ' ' || ch == 0x7f || ch == '~' || ch == '^' || ch == ':' || ch == '\\') return 1; /* 2.13 Pattern Matching Notation */ diff --git a/t/t1402-check-ref-format.sh b/t/t1402-check-ref-format.sh index 7563043..ed4275a 100755 --- a/t/t1402-check-ref-format.sh +++ b/t/t1402-check-ref-format.sh @@ -30,6 +30,9 @@ invalid_ref 'heads/foo.lock' valid_ref 'heads/foo@bar' invalid_ref 'heads/v@{ation' invalid_ref 'heads/foo\bar' +invalid_ref "$(printf 'heads/foo\t')" +invalid_ref "$(printf 'heads/foo\177')" +valid_ref "$(printf 'heads/fu\303\237')" test_expect_success "check-ref-format --branch @{-1}" ' T=$(git write-tree) &&
-- 1.7.6.8.gd2879