Re: [PATCH] for-each-ref: add split message parts to %(contents:*).
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 1, 2011, 17:16 UTC
- Message-ID
- <7vwrdsw5ci.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20110901162222.GC15018@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> We could either leave %(subject) with its historical behavior, or fix it > to handle multi-line subjects. Although it's technically a regression to > change it, I tend to think it is simply a bug, as it doesn't match what > the rest of git (like "git log --format=%s") does.
I think %(subject) should be updated to match %(contents:subject) as a bugfix, so %(body) should be adjusted to prevent "%(subject)%(body)" from duplicating lines.
Thanks.
Side note. We probably would want to borrow from pretty-formats to allow us to say %(subject)%(+body) or something...