git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/3] git-p4: Add test case for complex branch import

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 25, 2012, 04:02 UTC
Message-ID
<7vwr8g1lbx.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAOpHH-UxD37v7N3U9A0c_MnzSjOcF6eJCx2WdHRKf2CFoYy_tg@mail.gmail.com>
Vitor Antunes <vitor.hda@gmail.com> writes:
Show 14 quoted lines
>>>> +             p4 submit -d "branch5"
>>>
>>> That's a strange quoting convention. Why are "branch4" and "branch5"
>>> enclosed in double quotes while "integrate" and "submit" aren't?
>>> (rhetorical: do not quote these branch names without a good reason).
>>
>> There is no reason that I can remember to have those enclosed in double
>> quotes. Will double check in my local branches at home tonight. Anyway,
>> expect a fix for this in v3.
>
> I now see why I added the quotes. The -d option is used to input the
> description of the commit, which can contain spaces and other special
> characters. Admittedly they are not required in this case, but from a
> consistency point of view I would prefer to keep them.

Hmm, the argument "branch5" made it look like it is the name of the branch you are giving here. If it is supposed to be human-readable free-form text description, I would prefer to see it as such, e.g.

	p4 submit -d "integrate changes on branch #1 to branch #5"
or something like that.
Previous: Vitor Antunes
Message 15 of 15 in “git-p4: Search for parent commit on branch creation”
  1. 0/3 git-p4: Search for parent commit on branch creationVitor Antunes, Jan 21, 2012
  2. 1/3 git-p4: Add checkpoint() taskVitor Antunes, Jan 21, 2012
  3. 2/3 git-p4: Search for parent commit on branch creationVitor Antunes, Jan 21, 2012
  4. Junio C HamanoJan 21, 2012
  5. Vitor AntunesJan 23, 2012
  6. 3/3 git-p4: Add test case for complex branch importVitor Antunes, Jan 21, 2012
  7. Junio C HamanoJan 21, 2012
  8. Luke DiamandJan 21, 2012
  9. Pete WyckoffJan 21, 2012
  10. Vitor AntunesJan 23, 2012
  11. Pete WyckoffJan 23, 2012
  12. Vitor AntunesJan 25, 2012
  13. Pete WyckoffJan 25, 2012
  14. Vitor AntunesJan 25, 2012
  15. Junio C HamanoJan 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.