From: Junio C Hamano Date: Wed, 25 Jan 2012 04:02:10 GMT Subject: Re: [PATCH v2 3/3] git-p4: Add test case for complex branch import Message-ID: <7vwr8g1lbx.fsf@alter.siamese.dyndns.org> In-Reply-To: Vitor Antunes writes: >>>> + p4 submit -d "branch5" >>> >>> That's a strange quoting convention. Why are "branch4" and "branch5" >>> enclosed in double quotes while "integrate" and "submit" aren't? >>> (rhetorical: do not quote these branch names without a good reason). >> >> There is no reason that I can remember to have those enclosed in double >> quotes. Will double check in my local branches at home tonight. Anyway, >> expect a fix for this in v3. > > I now see why I added the quotes. The -d option is used to input the > description of the commit, which can contain spaces and other special > characters. Admittedly they are not required in this case, but from a > consistency point of view I would prefer to keep them. Hmm, the argument "branch5" made it look like it is the name of the branch you are giving here. If it is supposed to be human-readable free-form text description, I would prefer to see it as such, e.g. p4 submit -d "integrate changes on branch #1 to branch #5" or something like that.