Re: [PATCH] send-email: make annotate configurable

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 9, 2012, 18:07 UTC
Message-ID: <7vwr5owzgz.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpqaa2n7rvd.fsf@bauges.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

Show 10 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> ...
>> As long as there is --no-annotate to cancel a configured value for
>> one-shot invocation (I didn't check, but it should be added if there isn't
>> already one), I think this change makes sense (I admit that I do not use
>> the --annotate option myself, though).
>
> I almost always use --annotate, so this option definitely makes sense
> for me (I usually call send-email through an alias that adds --annotate
> anyway).

I do not doubt the usefulness of it, but if there is no --no-annotate, it would make the new variable unusable for those who would never run it without --annotate option; while you said "almost always", you didn't give us any useful information, so I had to check ;-) It turns out that

    $ git send-email --no-annotate </dev/null

errors out with "unrecognized argument: --no-annotate", which first needs to be addressed before the configuration variable can become useful.