Re: [PATCH] send-email: make annotate configurable
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 11, 2012, 15:46 UTC
- Message-ID
- <7v62d6nued.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <vpqaa2i61ty.fsf@bauges.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 14 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > >> Junio C Hamano <gitster@pobox.com> writes: >> >>> I do not doubt the usefulness of it, but if there is no --no-annotate, it >>> would make the new variable unusable for those who would never run it >>> without --annotate option >> >> Sorry; I meant to say "for those who mostly but not always run it with >> the --annotate option". > > Actually, I guess you also meant "and who sometimes use older versions > of Git", since the --no-annotate is there for people who always use the > new version.
Not really. I didn't even have that in mind, and I agree with below.
Show 5 quoted lines
> I don't think we can do anything for it. Any patch that introduces a new > command-line option has the same issue. The only solution is on the user > side: use only features that work for all versions of Git you use. In > this case, it means "wait for all your machines to upgrade Git before > setting sendemail.annotate".
And for that to work well, it is most sensible for the version that introduces the configuration variable to make sure that the --no-annotate command line override also is there, as the override becomes even more necessary because of the configuration variable.