Re: [PATCH] gitweb-lib.sh: Set up PATH to use perl from /usr/bin

From: Junio C Hamano <gitster@pobox.com>
Date: May 1, 2012, 16:44 UTC
Message-ID: <7vwr4vam0m.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201205011323.45190.tboegi@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

Show 16 quoted lines

> When there are different version of perl installed on the machine,
> the $PATH may point out a different version of perl than /usr/bin.
> One example is to have /opt/local/bin/perl before /usr/bin/perl.
> ...
> diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh
> index 21d11d6..a016142 100644
> --- a/t/gitweb-lib.sh
> +++ b/t/gitweb-lib.sh
> @@ -113,4 +113,7 @@ perl -MCGI -MCGI::Util -MCGI::Carp -e 0 >/dev/null 2>&1 || {
>  	test_done
>  }
>  
> +PATH=/usr/bin/:$PATH
> +export PATH
> +
>  gitweb_init

This is wrong.

What makes you think /usr/bin always has saner version of tools than those in the directories that the user explicitly listed earlier on her $PATH?

If anything it should be honoring $PERL_PATH that is set in the Makefile.