git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t/gitweb-lib: use $PERL_PATH to run gitweb

From
Jeff King <peff@peff.net>
Date
May 1, 2012, 17:55 UTC
Message-ID
<20120501175500.GA24258@sigill.intra.peff.net>
In-Reply-To
<4FA02274.6070601@web.de>

The current code runs "perl gitweb.cgi" to test gitweb. This will use whatever version of perl happens to be first in the PATH. We are better off using the specific perl that the user specified via PERL_PATH, which matches what gets put on the #!-line of the built gitweb.cgi.

Signed-off-by: Jeff King <peff@peff.net>
---
On Tue, May 01, 2012 at 07:50:44PM +0200, Torsten Bögershausen wrote:
> > Torsten, does that fix your problem?
> Yes, it does.
OK, here it is with a commit message.
 t/gitweb-lib.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh
index 21d11d6..ae2dc46 100644
--- a/t/gitweb-lib.sh
+++ b/t/gitweb-lib.sh
@@ -69,7 +69,7 @@ gitweb_run () {
 	# written to web server logs, so we are not interested in that:
 	# we are interested only in properly formatted errors/warnings
 	rm -f gitweb.log &&
-	perl -- "$SCRIPT_NAME" \
+	"$PERL_PATH" -- "$SCRIPT_NAME" \
 		>gitweb.output 2>gitweb.log &&
 	perl -w -e '
 		open O, ">gitweb.headers";
-- 
1.7.10.630.g31718
Previous: Junio C HamanoNext: Zbigniew Jędrzejewski-Szmek
Message 9 of 12 in “gitweb-lib.sh: Set up PATH to use perl from /usr/bin”
  1. gitweb-lib.sh: Set up PATH to use perl from /usr/binTorsten Bögershausen, May 1, 2012
  2. Zbigniew Jędrzejewski-SzmekMay 1, 2012
  3. Jeff KingMay 1, 2012
  4. Junio C HamanoMay 1, 2012
  5. Zbigniew Jędrzejewski-SzmekMay 1, 2012
  6. Jeff KingMay 1, 2012
  7. Torsten BögershausenMay 1, 2012
  8. Junio C HamanoMay 1, 2012
  9. t/gitweb-lib: use $PERL_PATH to run gitwebJeff King, May 1, 2012
  10. Consistently use perl from /usr/bin/ for scriptsZbigniew Jędrzejewski-Szmek, May 1, 2012
  11. Randal L. SchwartzMay 1, 2012
  12. Junio C HamanoMay 1, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.